Skip to content

test: enforce exit code in test-http-server-stale-close - #65198

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:test-http-server-stale-close-exit-0
Open

test: enforce exit code in test-http-server-stale-close#65198
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:test-http-server-stale-close-exit-0

Conversation

@aduh95

@aduh95 aduh95 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Until #59357 merged, we were failing to detect the forked process was erroring out

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 10, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95 force-pushed the test-http-server-stale-close-exit-0 branch from 415b627 to 132e894 Compare August 10, 2026 16:01
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.32%. Comparing base (536aca7) to head (132e894).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65198   +/-   ##
=======================================
  Coverage   90.32%   90.32%           
=======================================
  Files         760      760           
  Lines      248525   248526    +1     
  Branches    46901    46897    -4     
=======================================
+ Hits       224472   224491   +19     
+ Misses      15471    15462    -9     
+ Partials     8582     8573    -9     

see 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

daltino

This comment was marked as resolved.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants